Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EPIC] Upgrade to feathers 5.0.0 #7645

Closed
75 tasks done
Tracked by #8224
speigg opened this issue Feb 28, 2023 · 1 comment · Fixed by #7883 or #8044
Closed
75 tasks done
Tracked by #8224

[EPIC] Upgrade to feathers 5.0.0 #7645

speigg opened this issue Feb 28, 2023 · 1 comment · Fixed by #7883 or #8044
Assignees
Labels
Milestone

Comments

@speigg
Copy link
Member

speigg commented Feb 28, 2023

https://github.com/feathersjs/feathers/releases/tag/v5.0.0

Issues Found in Feathers Typing:

  • When querying find from client, if we pass pagination as false then it returns data in array. But if we pass pagination as undefined, then data is always retured as Paginated object though return typings show it to be either Paginated object or Array. Therefore, we have to explicitly parse the result to Paginated object.
  • When querying find from client, if we pass pagination as false then it returns data in array. We have to first convert that response to any and then to Array.
  • In authentication-setting service when we override patch method we have to convert object to strings before passing to super._patch method. Though as per typings, super._patch method expects them to be object.
@hanzlamateen hanzlamateen reopened this Apr 18, 2023
@hanzlamateen hanzlamateen reopened this Apr 18, 2023
@HexaField HexaField reopened this Jun 5, 2023
@HexaField
Copy link
Member

HexaField commented Jun 20, 2023

@HexaField HexaField changed the title Upgrade to feathers 5.0.0 [EPIC] Upgrade to feathers 5.0.0 Jun 23, 2023
@HexaField HexaField added epic and removed story - 8 labels Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment