Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

converters the probs into np array if its already not #9

Merged
merged 1 commit into from Apr 23, 2021

Conversation

sai-krishna-msk
Copy link
Contributor

smile_imbalance() funciton argument "probs" does not specify that it is required to be numpy array, but it does so i have added that data type in the argument letting the user know if he/she is to refer to the docs and i have also added a line np.array() which is an idempotent operation(if the array passed is already numpy array then it does nothing but if its not it changes the list into numpy array)

Suggestion

  • If possible can you guys consider adding "save_plot_path" method to each function, so that when this package is used in production (which i am and people considering Continuous model delivery would use) all these plots could be saved to a particular directory for data scientists to look at later since in production, code would be used in scripts running on EC2 or other cloud servers and not on jupyter notebooks
  • My use case is I am retraining the model every week and XAI allows me to generate a evaluation report allowing me to remotely decide weather to push this weeks mode into production
  • I considered adding it myself but i was not sure if this is the direction you guys wanted to take

Thank you

'smile_imbalance()' funciton arguments does not specify that probs argument is required to be numpy array, but it does so i have added that data type in the argument letting the user know and i have also added a line 'np.array()' which is a idempotent operation(if the array passed is already numpy array then it does nothing but if its not its changes the list into numpy array)
@axsaucedo
Copy link
Contributor

Thank you for the contribution @sai-krishna-msk - looks good. In regards to your suggestion, it seems inerseting, are you currently saving the charts manually or how do you achieve this?

@axsaucedo axsaucedo merged commit 57d1be0 into EthicalML:master Apr 23, 2021
@sai-krishna-msk
Copy link
Contributor Author

sai-krishna-msk commented Apr 23, 2021

Thank you for the contribution @sai-krishna-msk - looks good. In regards to your suggestion, it seems inerseting, are you currently saving the charts manually or how do you achieve this?

Hi @axsaucedo , yeah I'm using mlflow to log all the metrics and plots(so though the training happenes on a remote server I can view the results)

For now I've just downloaded this repository and made necessary changes suitable to my project, but yeah I was wondering maybe other people might also have this requirement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants