Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup automated CI testing for PRs using GitHub actions #114

Closed
axsaucedo opened this issue Jan 16, 2021 · 5 comments
Closed

Setup automated CI testing for PRs using GitHub actions #114

axsaucedo opened this issue Jan 16, 2021 · 5 comments
Labels
good first issue Good for newcomers
Projects

Comments

@axsaucedo
Copy link
Member

Currently all PRs that have been contributed require pulling the specific branch and running the tests. It would provide much more speedy development cycles especially for contributors through automated CI builds that show on each of the PRs.

This PR encompasses exploring setting up automated CI tests initially for C++, but also for the python tests.

@axsaucedo axsaucedo added this to To do in 0.5.2 via automation Jan 16, 2021
@axsaucedo axsaucedo added the good first issue Good for newcomers label Jan 16, 2021
@alexander-g
Copy link
Contributor

alexander-g commented Jan 16, 2021

I had this lying around for some time already, but not yet finished. Will take a look again.
For tests one can use swiftshader CPU implementation of Vulkan. However it does not support GLSL

@axsaucedo
Copy link
Member Author

Wow swiftshader looks awesome - interestingly enough I have been wanting to find something for quite a LONG time now, I have an open issue in the VK HPP repo which has had no movement KhronosGroup/Vulkan-Hpp#734

Haha good point on the glsl piece! Having said that tho, I would still be keen to explore the point about just installing shaderc, as potentailly that could make sure that it's always possible to pass string shaders (without the need to first convert them into spirv explicitly with the glsl dependency).

The point on swiftshader is very interesting tho - have you had a chance to try it by any chance?

@alexander-g
Copy link
Contributor

Yes it works fine. I'm already using it for CI in a private repo.

@axsaucedo
Copy link
Member Author

Interesting. Do you have a snippet that you coudl share? Or is this something you think you could add to the cmake file for the tests? This would really bring a lot of value as then it would be possible to set up github actions to run the tests on every PR submitted

@alexander-g alexander-g mentioned this issue Jan 16, 2021
@alexander-g
Copy link
Contributor

Here are also Swiftshader Windows binaries. However I remember I got a segfault when using Kompute Python with it. The Vulkan sample apps like vkcube.exe work fine however.
Will take a look at it sometime later again.

vk_swiftshader.dll
vk_swiftshader.debug.dll

@axsaucedo axsaucedo moved this from To do to Done in 0.5.2 Jan 30, 2021
@axsaucedo axsaucedo added this to To do in 0.6.0 via automation Jan 30, 2021
@axsaucedo axsaucedo removed this from Done in 0.5.2 Jan 30, 2021
@axsaucedo axsaucedo moved this from To do to Done in 0.6.0 Jan 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
No open projects
0.6.0
Done
Development

No branches or pull requests

2 participants