Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to spdlog in python module #122

Closed
axsaucedo opened this issue Jan 27, 2021 · 1 comment · Fixed by #123
Closed

Remove references to spdlog in python module #122

axsaucedo opened this issue Jan 27, 2021 · 1 comment · Fixed by #123

Comments

@axsaucedo
Copy link
Member

Since we now use the python logger via #118, there is no longer need to have references to spdlog

@alexander-g
Copy link
Contributor

One issue with the python logger I've noticed is that it does not automatically format the strings as spdlog does.
E.g: SPDLOG_DEBUG("{}", 777) will be displayed as "{}" in Python. This should be easily fixable though, because python also allows "{}".format(777)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants