Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose ability to create barriers in OpTensor operations #45

Closed
axsaucedo opened this issue Sep 6, 2020 · 1 comment · Fixed by #182
Closed

Expose ability to create barriers in OpTensor operations #45

axsaucedo opened this issue Sep 6, 2020 · 1 comment · Fixed by #182
Labels
enhancement New feature or request
Projects

Comments

@axsaucedo
Copy link
Member

Currently the optensor operations explicitly do not create a barrier, but there may be situations where this may be desired. Identify whether there are usecases where this would be relevant and explore best ways to expose the barrier creation (whether as a constructor parameter, or potentially as a completely separate default operation).

@axsaucedo axsaucedo added the enhancement New feature or request label Sep 6, 2020
@axsaucedo axsaucedo added this to To do in 0.3.0 Sep 6, 2020
@axsaucedo
Copy link
Member Author

It will be important to ensure the barriers are created, or that at least explicit requirements are made intuitive or explicit to the users in situations where it would cause issues, such as the OpTensor commands such as sync or copy, where the record step woudl perform a copy, and the postSubmit would perform a mapdatafromhost. This would work as long as there is a cpu barrier in the sequence submit, but if there isn't this would cause issues (it would involve fence and barriers).

@axsaucedo axsaucedo removed this from To do in 0.3.0 Sep 13, 2020
@axsaucedo axsaucedo added this to To do in 0.4.0 Sep 13, 2020
@axsaucedo axsaucedo removed this from To do in 0.4.0 Oct 18, 2020
@axsaucedo axsaucedo added this to To do in 0.5.0 Oct 24, 2020
@axsaucedo axsaucedo removed this from To do in 0.5.0 Nov 8, 2020
@axsaucedo axsaucedo added this to To do in 0.7.0 via automation Nov 8, 2020
0.7.0 automation moved this from To do to Done Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
0.7.0
Done
Development

Successfully merging a pull request may close this issue.

1 participant