Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ubuntu CI #115

Merged
merged 2 commits into from Jan 16, 2021
Merged

Ubuntu CI #115

merged 2 commits into from Jan 16, 2021

Conversation

alexander-g
Copy link
Contributor

Basic CI for Ubuntu including (partial) tests as discussed in #114.
This uses Swiftshader CPU implementation as Vulkan ICD. The precompiled binaries are downloaded from Dropbox, for a long term solution you might want to store them somewhere else.
Only tests that don't require GLSL are run because Swiftshader does not support it.

@axsaucedo
Copy link
Member

So fast - looks great, really interesting how simple the setup looks! This is very good, a couple of thoughts / questions:

  • Instead of the dropbox link is there a more formal package/source, or could we just add this binary into the repo?
  • I see you are currently running the tests that don't require the shader compilation, I think we can merge this initial first, but do you think installing shaderc could be enough to address this in the image?
  • Is there a way to run this github action in this PR before merging? Or is that something that will only run once merged?
    Thanks!

@axsaucedo axsaucedo self-requested a review January 16, 2021 16:49
@axsaucedo axsaucedo added the enhancement New feature or request label Jan 16, 2021
@axsaucedo axsaucedo added this to In progress in 0.5.2 via automation Jan 16, 2021
Copy link
Member

@axsaucedo axsaucedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can merge this and then we can re-assess how to improve iteratively, as this in itself would be massively useful

@axsaucedo axsaucedo merged commit 6501c59 into KomputeProject:master Jan 16, 2021
0.5.2 automation moved this from In progress to Done Jan 16, 2021
@alexander-g
Copy link
Contributor Author

I could not find official binaries so I've compiled them myself on my device and uploaded to DropBox. Compiling takes quite a long time
I'm not familiar with shaderc so I don't know.

@axsaucedo
Copy link
Member

Works like a charm 👍 awesome contribution @alexander-g
image

@alexander-g
Copy link
Contributor Author

Glad to help

@alexander-g alexander-g deleted the CI_CPP_ubuntu branch January 17, 2021 10:30
@axsaucedo axsaucedo added this to In progress in 0.6.0 via automation Jan 30, 2021
@axsaucedo axsaucedo removed this from Done in 0.5.2 Jan 30, 2021
@axsaucedo axsaucedo moved this from In progress to Done in 0.6.0 Jan 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
0.6.0
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants