Disallowing zero sized tensors #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axsaucedo
requested changes
Jan 30, 2021
test/TestOpTensorCreate.cpp
Outdated
| mgr.evalOpDefault<kp::OpTensorCreate>({ tensorA }); | ||
| } catch( const std::runtime_error& err ) { | ||
| // check exception | ||
| ASSERT_STREQ("Kompute Tensor attempted to create a zero-sized buffer", err.what() ); |
There was a problem hiding this comment.
StrEq comparison may be too brittle for test, eventually it would be interesting to explore structured errror/exception handling, but for now is there a way to just have a check for "zero sized" in the string?
There was a problem hiding this comment.
May also be worth adding an extra comment in the constructor so it's explicit that it will throw an error if empty tensor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vulkan specs disallow zero-sized buffers. I've run into segfaults accidentally trying to create some and this was mentioned in #14.
I've added an exception with an error message for easier fault finding. The exception is thrown right before buffer creation because that's where the segfault would happen, but one might consider throwing it already in the constructor.