Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues with setup.py for pip >=10 #15

Closed
akosv opened this issue Apr 25, 2018 · 2 comments
Closed

Issues with setup.py for pip >=10 #15

akosv opened this issue Apr 25, 2018 · 2 comments
Assignees
@EtienneCmb
Labels
bug

Comments

@akosv
Copy link

akosv commented Apr 25, 2018

Hello,

A quick note. I had to change the following two import statements:

  1. from pip.req import parse_requirements -> from pip._internal.req import parse_requirements
  2. from pip.download import PipSession # pylint:disable=E0611 -> from pip._internal.download import PipSession # pylint:disable=E0611

in setup.py to make it work with pip v10.0.1

Thanks.
@EtienneCmb EtienneCmb self-assigned this May 6, 2018
@EtienneCmb EtienneCmb added the bug label May 6, 2018
@EtienneCmb
Copy link
Owner

Hi @akosv , thanks for the feedback. Do you think you can propose a PR to fix it?

Thanks,

@EtienneCmb EtienneCmb mentioned this issue May 6, 2018
Closed
@EtienneCmb
Copy link
Owner

This issue should be solved. See c317c5f and 6008f8b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EtienneCmb EtienneCmb

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@akosv @EtienneCmb