Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix displayed stats for "over time" effects #222

Closed
afjback opened this issue Aug 10, 2019 · 2 comments
Closed

Fix displayed stats for "over time" effects #222

afjback opened this issue Aug 10, 2019 · 2 comments
Labels

Comments

@afjback
Copy link
Contributor

afjback commented Aug 10, 2019

Ingame:
bsp-ra-ingame
displays 318 reduced armor for 3 seconds (scheme: effect , duration)

Vault:
bsp-ra-vault
displays 1080 (three times more) reduced armor for 3 seconds, which is wrong.
Seems like vault gets these stats:
offensiveSlowDefensiveReductionDurationMin,3.000000, offensiveSlowDefensiveReductionMin,360.000000,
and multiply them for some reason (scheme: effect*duration , duration). For this case 360 RA for 3 seconds doesn't mean 1080 in whole.

@EtienneLamoureux EtienneLamoureux changed the title Wrong displayed stats for timed effects Fix displayed stats for "over time" effects Dec 2, 2019
@ejfudd
Copy link
Contributor

ejfudd commented Apr 29, 2020

Just looking at the screen grabs, it actually appears that there are two different effects. Looking at the wording of the format string the behavior may be correct for that particular format.
To fix this we would need to look at a few "over time" items from both the base game and expansions to verify the tags and change the attribute parsing accordingly.

Edit:
Looking further it appears that there are two different tags DamageFixedSingleFormatTime and DamageSingleFormatTime and two different behaviors. The Fixed version should use the raw damage value and the non-Fixed should multiply the damage value and the duration.
I checked two attributes offensiveSlowBleeding and offensiveSlowDefensiveReduction where both had a min value and duration, yet Bleeding used the non-fixed format and DefensiveReduction used the fixed format.

The fixed version is currently not used by TQVault, but I do not see a way that they are differentiated in the the database. It would be simple enough to add an something in for this single attribute, but it does not include any others that may have been missed.

@Ninakoru
Copy link
Contributor

Well, it happens I fixed this one while resolving other tooltip issues:

https://github.com/Ninakoru/TQVaultAE/releases/tag/3.8.8-TEST3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants