-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do you need anything from xterm.js? #542
Comments
@Tyriar How about getting to work on TrueColor? :/ |
@MrKumaPants we're getting fairly close to done with the buffer improvements that will allow us to do true color without taking way too much memory xtermjs/xterm.js#791 |
Hey Daniel, thanks for reaching out! I've recently posted two feature requests that would definitely make it easier to switch over to xterm in the future: xtermjs/xterm.js#1803 I'm definitely looking forward to the WebGL renderer as well. One major pain of integrating xterm is how monkeypatching-resistant it is - with a lot of stuff locked away within closures - e.g. it's absolutely impossible to patch any event handlers installed with I've considered importing |
Also, what's the state of ConPTY integration in node-pty? The PR looks feature-complete, but I hadn't have a chance to test it yet. I wouldn't mind adding it to Terminus before it's released/stable. |
I commented on those 2 issues.
Do you have some examples of what you're trying to do here?
Ditto, it's not a priority to push that in currently but I'm going to keep the PR up to date in the meantime.
It doesn't work in Electron 2 so it's been blocked on VS Code adopting Electron 3, which is likely to happen in the next release so expect me to clean up and merge that PR soon 😃 |
Thanks! |
@MrKumaPants I've just added True Color support in #23 |
xterm frontend is now the default |
Hi @Eugeny, I'm one of the maintainers on xterm.js. I noticed that hterm appears to be the default frontend and was wondering if there were particular issues on our side for this?
The text was updated successfully, but these errors were encountered: