Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cygwin/MSYS2 pty support #5453

Open
ysc3839 opened this issue Jan 12, 2022 · 3 comments
Open

Cygwin/MSYS2 pty support #5453

ysc3839 opened this issue Jan 12, 2022 · 3 comments

Comments

@ysc3839
Copy link
Contributor

ysc3839 commented Jan 12, 2022

Is your feature request related to a problem? Please describe.
When execute tmux on Cygwin or MSYS2 with tabby, tmux exited with open terminal failed: not a terminal.
However tmux works well with mintty.

Describe the solution you'd like
IIRC mintty is using Cygwin/MSYS2 pty API. Tabby should also use pty instead of Windows console host.

Describe alternatives you've considered
None

Additional context
Related issue: #2319

@ysc3839
Copy link
Contributor Author

ysc3839 commented Jan 26, 2022

@Eugeny Hello, did you forget this issue?

@Eugeny
Copy link
Owner

Eugeny commented Jan 29, 2022

This seems to be an issue with MSYS2 itself reporting a different tty device when not running in its own terminal - the same happens for other terminals too: vercel/hyper#3608 alacritty/alacritty#1687 microsoft/terminal#5132

@ysc3839
Copy link
Contributor Author

ysc3839 commented Jan 30, 2022

I think the correct solution is to use Cygwin pty directly, without going through Windows Console.
Maybe it's because Windows Console is not fully compatible with UNIX tty, so Cygwin report it's not a try.
My solution is to write a connector executable using C++, running in Cygwin environment, and communicate with tabby main process using ZeroMQ.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants