Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search and press esc, tabby not returning to command line input #7004

Closed
qingqi opened this issue Aug 18, 2022 · 6 comments
Closed

search and press esc, tabby not returning to command line input #7004

qingqi opened this issue Aug 18, 2022 · 6 comments

Comments

@qingqi
Copy link

qingqi commented Aug 18, 2022

Version: 1.0.183
Platform: Windows x64 10.0.19044
Plugins: none
Frontend: xterm

steps:
1 ctrl + shift + F, to search some text
2 press ESC key
3 input some command
result:
the shell command line not activated, and the command not showed
expect:
esc can return to command line interface

@konstantin83
Copy link

+1
Also, how do you even see the search results? It's should be extremely visible, but instead I almost can't see it.
iTerm2 on MacOS do it very handy — all found elements are highlighted on the terminal, but current is extremely highlighted, so you don't spend time finding it on the screen.
Also it nothin is found, it should result in some kind of red color of search field.

@Eugeny
Copy link
Owner

Eugeny commented Aug 19, 2022

Nothing found:

image

Result highlight:

image

@konstantin83
Copy link

Result highlight:

Eugeny, how did you manages this highlighting?

@Eugeny
Copy link
Owner

Eugeny commented Aug 19, 2022

This is actually the default highlighting style. I'm wondering if you might be using a light theme and it could affect the way highlight happens?

@konstantin83
Copy link

How may I check this?

@konstantin83
Copy link

if you might be using a light theme

If you mean Ubuntu light/dark theme, then yes I'm using light. But I switched to dark for the test and nothing changed.

@Eugeny Eugeny closed this as completed in 96b3a40 Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants