Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search impact on copy paste #9196

Open
gitthangbaby opened this issue Nov 1, 2023 · 6 comments
Open

Search impact on copy paste #9196

gitthangbaby opened this issue Nov 1, 2023 · 6 comments
Labels

Comments

@gitthangbaby
Copy link

Describe the problem:
When search (CtrlShiftF) is open, clicking on the shell will copy the search keyword. Even when it's emptied.

To Reproduce:
Open search window
Type some text to search bar (if it's big enough, looks like it graphically overlaps with standard buttons)
Click on the shell (not selecting)
Paste
** Expected result:
-> whatever was in clipboard should be pasted
** unexpected result:
-> the search keyword is pasted
Empty the search keyword
Click on the shell (not selecting)
Paste
** Expected result:
-> whatever was in clipboard should be pasted
** unexpected result:
-> the word "direct" is pasted

@Clem-Fern
Copy link
Contributor

Clem-Fern commented Nov 1, 2023

Hi @gitthangbaby,

It looks very similar to an old issue that should be fixed now.
Which version do you use?

@gitthangbaby
Copy link
Author

gitthangbaby commented Nov 1, 2023

Hi @gitthangbaby,

Which version do you use?

It's 1.0.201.

Here the Win+V clipboard history shows how "direct" is inserted into clipboard everytime I come back to a session and copy something. Before each paste, I have to recall the previous item from history:
image

Visually, can't press those 3 search buttons, because there are window buttons:
image

@mysterin
Copy link

The same question.
My version is 1.0.197, when I paste secondly, the word is the search keyword.

@Clem-Fern
Copy link
Contributor

I wasnt able to reproduce this :/

Did the Copy on Select option is enabled ?
If so, could you disable it and try to reproduce this issue again ?

@gitthangbaby
Copy link
Author

gitthangbaby commented Nov 17, 2023

On my side, can't reproduce with Copy on Select off because it's part of the steps to reproduce.

I thought running mc helps (lot of issues arise from that #8884 (comment)) to reproduce, but not needed in this case: better use a search keyword that is found on the screen. Like @mysterin said, double click a text, and right click twice. Second paste is the search string.

update: incredible but today Tabby was inserting the last searchword to my clipboard all day, replacing the copied record with its searchword. And today I didn't even use Tabby. The whole Windows-V history is full of reinserted searchword.

@gitthangbaby
Copy link
Author

gitthangbaby commented Feb 12, 2024

Visually, can't press those 3 search buttons, because there are window buttons: image

visual overlap issue can be 'fixed' by moving the tab location to the top (Settings\Window\Tabs).
the functional issue is reproduced from 197 to 207 on Windows & Linux. Can be mitigated by turning off Copy on Select (Terminal\Clipboard).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants