Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix KeyData.data_counts() with no data #222

Merged
merged 3 commits into from Sep 27, 2021
Merged

Fix KeyData.data_counts() with no data #222

merged 3 commits into from Sep 27, 2021

Conversation

takluyver
Copy link
Member

Closes #221

There are two related cases. If there are trains selected with no data, .data_counts() should give one zero entry per train selected. If there are no trains selected, it should return an array/series with length 0.

@takluyver takluyver added the bug Something isn't working label Sep 27, 2021
@takluyver takluyver added this to the 1.8 milestone Sep 27, 2021
Copy link
Member

@tmichela tmichela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@takluyver takluyver merged commit c6c9a26 into master Sep 27, 2021
@takluyver takluyver deleted the data-counts-empty branch September 27, 2021 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't instantiate multi-module detector access if any module has no data
2 participants