Fix pickling FileAccess objects with cloudpickle #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cloudpickle is an extended Pickle library used by projects like Dask and clusterfutures to send objects around. @tmichela found that it wasn't working with EXtra-data 1.10, probably because of #264.
The issue was the
FileAccess._from_pickleclassmethod. cloudpickle attempted to save this 'by value', and since it uses the file access registry, it tried to pickle the registry as well, and it can't handle the weakref objects stored there. The best option I can see is to make it a staticmethod instead (i.e. a plain function defined in a class), which cloudpickle pickles 'by reference' - i.e. it stores the path to import and look up the function in the destination.This would make subclassing FileAccess a bit more work, but I'm not aware of anyone doing that, and I wouldn't encourage it - subclasses are quite likely to break when details change.