Allow KeyData.ndarray to read into a pre-allocated array #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takluyver
reviewed
Apr 25, 2022
takluyver
reviewed
Apr 25, 2022
philsmt
force-pushed
the
feat/ndarray-out-argument
branch
from
6501f19
to
c57491d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed on the side while discussing AGIPD's memory problems during corrections, it' fairly easy to allow
KeyData.ndarray()to accept a pre-allocated array.I decided to only check for the correct shape rather than dtype, as
Dataset.read_direct's semantics allow for type coercion during reading.