Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: open run with data='all' when proc folder exists but is empty #317

Merged
merged 1 commit into from Jun 3, 2022
Merged

FIX: open run with data='all' when proc folder exists but is empty #317

merged 1 commit into from Jun 3, 2022

Conversation

tmichela
Copy link
Member

open_run expects a FileNotFoundError when opening data='all' if the proc folder does not exist. Sometimes, a proc folder is created, but does not contain any data. In this case, RunDirectory throws a generic Exception when a FileNotFoundException is expected.

JamesWrigley
JamesWrigley approved these changes Jun 2, 2022
View reviewed changes
Copy link
Member

@JamesWrigley JamesWrigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just ran into this, so I'll give it a sneaky LGTM.

@tmichela tmichela added the bug Something isn't working label Jun 3, 2022
@tmichela tmichela added this to the 1.12 milestone Jun 3, 2022
@tmichela tmichela merged commit 6b7c22a into master Jun 3, 2022
@tmichela tmichela deleted the fix/openRunDirNoData branch June 3, 2022 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesWrigley JamesWrigley JamesWrigley approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.12
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tmichela @JamesWrigley