Propagate the parallelize option in open_run() #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takluyver
reviewed
Sep 7, 2022
extra_data/tests/conftest.py
Outdated
| os.makedirs(proc_run_dir) | ||
| make_examples.make_spb_run(proc_run_dir, raw=False) | ||
|
|
||
| yield td, prop_dir, raw_run_dir, proc_run_dir |
There was a problem hiding this comment.
I agree that returning all these paths isn't the most elegant. I think you could skip returning prop_dir - the only place that it's used, it can easily be replaced with proc_run_dir. Then I think it's good enough.
There was a problem hiding this comment.
Good catch, fixed in f9fef4e.
|
Other than that, LGTM |
This comes up when using `open_run(data="all")`, which will make another call internally to load proc data with `open_run(data="proc")`. Since the parallelize option wasn't passed, the call to open proc data would use the default of `parallelize=True`.
JamesWrigley
force-pushed
the
propagate_parallelize
branch
from
ffe8648
to
f9fef4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comes up when using
open_run(data="all"), which will make another callinternally to load proc data with
open_run(data="proc"). Since theparallelize option wasn't passed, the call to open proc data would use the
default of
parallelize=True.Note: I refactored
test_open_run()to re-use the code for creating a mock root directory with raw and proc directories etc, but I'm not sure I like how messy it is to return so many paths from a fixture 馃し I could also copy and paste the setup lines intotest_open_run_daemonized().