Set ctx_closes when opening run using voview #375
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR aims to close #374 in which it's shown how the context manager is not set correctly when using voview files.
The changes can be tested with the example shown in the ticket:
I updated the tests accordingly.
On an unrelated note, I found that
psutil
is required to run tests, but is not in thetest
requirements, which I suppose was not noticed because most have thedocs
requirements.Thanks,
Cyril