Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix .ndarray(module_gaps=True) for xtdf detector data #432

Merged
merged 1 commit into from Jul 25, 2023
Merged

Fix .ndarray(module_gaps=True) for xtdf detector data #432

merged 1 commit into from Jul 25, 2023

Conversation

takluyver
Copy link
Member

Closes #428.

@takluyver takluyver added the bug Something isn't working label Jul 17, 2023
@takluyver takluyver added this to the 1.14 milestone Jul 17, 2023
RobertRosca
RobertRosca approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member

@RobertRosca RobertRosca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Poked around a bit and tested a few things by hand, looks good :)

LGTM 👍

@takluyver
Copy link
Member Author

Thanks!

@takluyver takluyver merged commit c40b05e into master Jul 25, 2023
10 checks passed
@takluyver takluyver deleted the fix/xtdf-ndarray-module-gaps branch July 25, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobertRosca RobertRosca RobertRosca approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.14
Development

Successfully merging this pull request may close these issues.

Components: .ndarray(module_gaps=True) is broken for XTDF detectors image keys
2 participants
@takluyver @RobertRosca