Fix alias loading for old proposals #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Old proposals would copy all data from raw into proc so they would always contain the same sources, so when open_run() picked the proc DataCollection to return it wouldn't include any aliases because those are only loaded once for raw data.
JamesWrigley
force-pushed
the
proc-aliases
branch
from
2cabf6e
to
91d82a8
Compare
|
LGTM, thanks! I'll probably just release master as 1.16 - it looks like all low-risk fixes anyway, and this seems simpler than splitting out this fix as 1.15.2. |
|
Thankee thankee 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old proposals would copy all data from raw into proc so they would always contain the same sources, so when open_run() picked the proc DataCollection to return it wouldn't include any aliases because those are only loaded once for raw data.
Would it be possible to make a patch release for this? Unfortunately without it one can't use aliases in DAMNIT context files for old proposals☹️