Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support selecting down DataCollection by SourceData objects #499

Merged
merged 1 commit into from Mar 11, 2024
Merged

Support selecting down DataCollection by SourceData objects #499

merged 1 commit into from Mar 11, 2024

Conversation

philsmt
Copy link
Contributor

@philsmt philsmt commented Mar 7, 2024

Seems like an obvious addition after SourceData became a public interface 馃し

Also adds missing tests for using KeyData in this place.

@philsmt philsmt requested a review from takluyver March 7, 2024 16:11
@takluyver takluyver added the enhancement New feature or request label Mar 11, 2024
@takluyver takluyver added this to the 1.17 milestone Mar 11, 2024
@takluyver
Copy link
Member

Thanks, LGTM!

@philsmt
Copy link
Contributor Author

philsmt commented Mar 11, 2024

Thanks for review!

@philsmt philsmt merged commit 381508b into master Mar 11, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takluyver takluyver Awaiting requested review from takluyver

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.17
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@philsmt @takluyver