Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve masking behavior #61

Merged
merged 7 commits into from Feb 28, 2020

Conversation

zhujun98
Copy link
Collaborator

Return a boolean mask for each masking operation.

@zhujun98 zhujun98 added the feature New feature label Feb 21, 2020
@zhujun98 zhujun98 added this to the Release 0.8.0 milestone Feb 21, 2020
@zhujun98 zhujun98 added this to In progress in Release planning via automation Feb 21, 2020
@zhujun98 zhujun98 force-pushed the improve_masking_behavior branch 7 times, most recently from 21e2316 to 85e0dca Compare February 25, 2020 12:50
@zhujun98 zhujun98 force-pushed the improve_masking_behavior branch 9 times, most recently from 2497629 to ec465db Compare February 28, 2020 09:13
- Prevent a (valid) corner case input of 'nanmean_image_data';
- Improve quality of benchmark code.
- nanmean, nanmedian, nanstd are used accordingly to deal with nans
- Use mask in azimuthal integration
- Move _compute_hist method into algorithms.statistics as a free
  function compute_roi_hist.
Mask POI and provide overall mask in ImageData.from_array
@zhujun98 zhujun98 force-pushed the improve_masking_behavior branch 2 times, most recently from db80b74 to 25187d2 Compare February 28, 2020 13:45
@zhujun98
Copy link
Collaborator Author

Since MID and Jola have been using it for the whole day, I assume this major change in principle works.

@zhujun98 zhujun98 merged commit 952a221 into European-XFEL:dev Feb 28, 2020
Release planning automation moved this from In progress to Done Feb 28, 2020
@zhujun98 zhujun98 deleted the improve_masking_behavior branch February 29, 2020 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
Development

Successfully merging this pull request may close these issues.

None yet

1 participant