Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label AGIPD-500k with M0-M7 module numbers #226

Merged
merged 1 commit into from Jun 5, 2023

Conversation

takluyver
Copy link
Member

@tmichela @philsmt @daniloefl - does this look right? Do you think anyone will be upset to lose the QxMy numbering?

image

Closes #223.

@philsmt
Copy link
Contributor

philsmt commented Jun 1, 2023

@tmichela Could you possibly ask about the labeling on the HED side? It was back then done on behalf of DET, so mileage may vary.

@philsmt philsmt closed this Jun 1, 2023
@philsmt philsmt reopened this Jun 1, 2023
@tmichela
Copy link
Member

tmichela commented Jun 2, 2023

Is the QxMy labeling actually used beyond the calibration services?

@takluyver
Copy link
Member Author

For other detectors, the QxMy pattern is certainly used - e.g. see these docs for AGIPD at MID: https://rtd.xfel.eu/docs/agipd-manual-mid/en/latest/introduction.html#naming-convention

Whether it's specifically used for AGIPD 500k is the question at hand. 🙂

@tmichela
Copy link
Member

tmichela commented Jun 5, 2023

Probably not, but who knows 🤷
To be safe, I'd maybe include both notation (QxMy (CHz)) but also that's probably not too important, so that's up to you.

@takluyver
Copy link
Member Author

If we don't know of anyone using the QxMy notation for AGIPD 500k, and it does look like the Mx notation is used (I looked in Karabo), let's try this and see if anyone complains.

@takluyver takluyver merged commit 30e5c0a into master Jun 5, 2023
12 checks passed
@takluyver takluyver deleted the agipd-500k-inspect-M0 branch June 5, 2023 07:20
@takluyver takluyver modified the milestones: 1.10, 1.11 Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AGIPD500K does not have the channel numbers shown in inspect()
3 participants