Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix calculation of module positions for JUNGFRAU #69

Merged
merged 1 commit into from May 19, 2021
Merged

Fix calculation of module positions for JUNGFRAU #69

merged 1 commit into from May 19, 2021

Conversation

takluyver
Copy link
Member

N tiles have N-1 gaps between them

cc @JunCEEE @dallanto

@takluyver
Fix calculation of module positions for JUNGFRAU
cf62352 
N tiles have N-1 gaps between them
@takluyver takluyver added the bug Something isn't working label Apr 30, 2021
@takluyver takluyver added this to the 1.3 milestone Apr 30, 2021
@dallanto
Copy link
Contributor

Thanks Jun for spotting and Thomas for the quick correction!

@kirienko kirienko self-requested a review May 18, 2021 18:15
kirienko
kirienko approved these changes May 18, 2021
View reviewed changes
Copy link
Contributor

@kirienko kirienko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, btw 😉

@takluyver takluyver merged commit 76659f5 into master May 19, 2021
@takluyver takluyver deleted the jf-from-mod-pos-off-by-gap branch May 19, 2021 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirienko kirienko kirienko approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@takluyver @dallanto @kirienko