Only inspect one file for detector_info #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
At some point we'll need to be smarter if reduced data has varying numbers of frames saved for different trains, but I'm not trying to tackle that here. |
tmichela
reviewed
Oct 22, 2019
|
Minor comment, LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This approximates the total number of frames in the run - but that wasn't the most useful statistic anyway, because it can vary among detector modules, and we were picking an arbitrary module.
In combination with #206, this should mean we only open one HDF5 file for lsxfel (once the run map is cached), rather than all files for that detector module. Long runs can have 20 sequence files, so this should be much faster.