Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Low Priority: Removal of view_as_windows from CUCIM if redundant #37

Open
Eve-ning opened this issue Aug 4, 2022 · 1 comment
Open

Comments

@Eve-ning
Copy link
Owner

Eve-ning commented Aug 4, 2022

currently in glcm_cupy/glcm/glcm.py, we have

from cucim.skimage.util.shape import \
    view_as_windows as view_as_windows_cucim

from glcm_cupy.utils import view_as_windows_cp

...

if USE_CUCIM:
    ij = view_as_windows_cucim(
        im_chn, (self._diameter, self._diameter)
    )
else:
    ij = view_as_windows_cp(im_chn, (self._diameter, self._diameter))

which may be redundant, if view_as_windows_cucim does not perform any essential speedup over view_as_windows_cp.

  • view_as_windows_cp is an adaptation of skimage.utils.view_as_windows, with cp.ndarray substituting np.ndarray
@Eve-ning
Copy link
Owner Author

Eve-ning commented Aug 4, 2022

This is not essential to fix, low priority.

@Eve-ning Eve-ning changed the title Removal of view_as_windows from CUCIM if redundant Low Priority: Removal of view_as_windows from CUCIM if redundant Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant