Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot run performance test via "npm run" #231

Closed
ronkorving opened this issue Jan 31, 2018 · 3 comments · Fixed by #236
Closed

Cannot run performance test via "npm run" #231

ronkorving opened this issue Jan 31, 2018 · 3 comments · Fixed by #236

Comments

@ronkorving
Copy link
Contributor

This is not a duplicate of #229

Output:

$ npm run benchmark

> eventemitter2@5.0.1 benchmark /Users/ronkorving/Projects/EventEmitter2
> node --reporter test/perf/benchmark.js

node: bad option: --reporter
npm ERR! code ELIFECYCLE
npm ERR! errno 9
npm ERR! eventemitter2@5.0.1 benchmark: `node --reporter test/perf/benchmark.js`
npm ERR! Exit status 9
npm ERR! 
npm ERR! Failed at the eventemitter2@5.0.1 benchmark script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/ronkorving/.npm/_logs/2018-01-31T01_45_38_512Z-debug.log
@RangerMauve
Copy link
Contributor

I wasn't involved in making the benchmarks, what does the --reporter option even do? Does removing it change anything?

@ronkorving
Copy link
Contributor Author

I have no idea what it's supposed to do :) Removing it makes it work. Output is what I would expect it to output...

@RangerMauve
Copy link
Contributor

Would you mind doing a PR for the change, then? 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants