Use Promise.allSettled instead of Promise.all to finish execution of all listeners #285
Conversation
|
@DigitalBrainJS what do you think? P.S.: Just now I saw you live in Kyiv, hope you and your family are safe |
|
Thank you for your patience, I've been AFK from open source projects due to having way too much to do with client work. Would you mind running benchmarks before and after so we could compare performance implications before we merge this in? |
|
@onhate Hi! May be an option to enable Promise.allSettled behaviour would be a better solution. |
|
Technically there are no differences on performance between all and allSettled, I couldn't find any article indicating that at least, they are both v8 implementations running on the core of it, I even looked on the source code of v8 and both implementations run the same way calling the function https://github.com/v8/v8/blob/main/src/builtins/promise-all.tq#L376 |
closes #283
On an application with multiple listeners to the same event when using Promise.all It rejects immediately upon any of the input promises rejecting or non-promises throwing an error, and will reject with this first rejection message / error.
While Promise.allSettled is typically used when you have multiple asynchronous tasks that are not dependent on one another to complete successfully, or you'd always like to know the result of each promise, which is the use case of having multiple listeners for the same event.