Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meteor 0.8.3 + IR 0.8.* : app freeze #741

Closed
Rebolon opened this issue Jul 31, 2014 · 12 comments
Closed

Meteor 0.8.3 + IR 0.8.* : app freeze #741

Rebolon opened this issue Jul 31, 2014 · 12 comments

Comments

@Rebolon
Copy link

Rebolon commented Jul 31, 2014

Hi,

i tried to upgrade my app to 0.8.3 but i failed :-(
I've also updated iron-router to 0.8.1 and then to 0.8.2 !

When i start the app, it seems to work weel on server-side
On client-side the browser freeze on route with subscriptions. Then the tab just crash.

I d'ont succeed to get any error messages for instance. But

  • in fact when i removed all waitOn() hooks then the app succeed to start on client side
  • if i put log in hooks, i can see that there is an infinite caal to waitOn() hooks

Thx

@teknomath
Copy link

I'm getting something similar....in the browser I see "Error: No uiManager configured on Router" after a lot of "Template not defined" messages. It seems to start off with an undefined at blaze-layout.js:132. This smells like the layout manager isn't being loaded....is that something Iron Router does?

@cmather
Copy link
Contributor

cmather commented Aug 1, 2014

@Rebolon, if your browser tab is crashing and you're seeing a cpu pegged, it's probably because of an infinite invalidation loop somewhere. Any chance we can see some code?

@teknomath, That's because you need to upgrade iron-router to 0.8.2 and Meteor to 0.8.3. Do this:

meteor update
mrt update iron-router
meteor remove blaze-layout

@teknomath
Copy link

@cmather, Thanks. It was a bit more complicated than that (other dependency problems, missing packages, misplaced files), but indeed that was exactly the issue. To fix it, I created a fresh new project, copied all my existing code into it, and then re-added (via mrt) all my important packages (leaving out the cruft). Probably needed to be done anyway. But hey, now I know how to reset a Meteor project!

@cmather
Copy link
Contributor

cmather commented Aug 1, 2014

Cool! Thanks for the follow up

On Jul 31, 2014, at 6:42 PM, Gregg Cooke notifications@github.com wrote:

@cmather, Thanks. It was a bit more complicated than that (other dependency problems, missing packages, misplaced files), but indeed that was exactly the issue. To fix it, I created a fresh new project, copied all my existing code into it, and then re-added (via mrt) all my important packages (leaving out the cruft). Probably needed to be done anyway. But hey, now I know how to reset a Meteor project!


Reply to this email directly or view it on GitHub.

@Rebolon
Copy link
Author

Rebolon commented Aug 1, 2014

@cmather it's a private repo but i can add you to the project if you want to check the code.

@Rebolon
Copy link
Author

Rebolon commented Aug 4, 2014

@cmather i've added you to the project

@Rebolon
Copy link
Author

Rebolon commented Aug 5, 2014

i've put a question on stackoverflow about this. There is also the code of the router, and a url of a sample app : http://stackoverflow.com/questions/25136239/meteor-0-8-3-iron-router-infinite-loop-inside-waiton-hook

@cmather
Copy link
Contributor

cmather commented Aug 13, 2014

Note to self: Look into maybe somehow preventing circular dependencies.

@cmather cmather added this to the Next Release milestone Aug 13, 2014
@cmather
Copy link
Contributor

cmather commented Aug 14, 2014

Might be related to: #742 (comment)

cmather added a commit that referenced this issue Aug 14, 2014
@DerMambo, @tmeasday: can you see if this fixes the issue for you? and
doesn't cause side effects that I'm not thinking of. Use the devel
branch of iron-router. Thanks!

See issues:
* #742.
* #741
@Rebolon
Copy link
Author

Rebolon commented Sep 1, 2014

issue has been soved with iron-router v0.8.2
Thanks

@Rebolon Rebolon closed this as completed Sep 1, 2014
@Rebolon Rebolon reopened this Sep 2, 2014
@Rebolon
Copy link
Author

Rebolon commented Sep 2, 2014

Sorry, to closed the issue, but in fact it still fail (hard to be back from holydays), it's just that i moved the code from waitOn to onBeforeAction and that i d'ont remember that.

@tmeasday
Copy link
Contributor

Going to close this as it seems unlikely to be relevant for 1.0.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants