feat: add IntelliJ IDEA plugin for generating with bzlgen #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODO:
Currently bzlgen needs to be installed globally for this to work, or on the PATH somewhere, I wonder if we can rollup bzlgen and bundle it in the jar, at least then the plugin and binary are versioned in step |
mattem
commented
May 19, 2020
Comment on lines
+60
to
+64
| if (selected.isDirectory()) { | ||
| selected.refresh(false, false); | ||
| } else { | ||
| selected.getParent().refresh(false, false); | ||
| } |
There was a problem hiding this comment.
I'm not convinced this is doing what I think it's doing
| name = "intellij_ce_2019_3", | ||
| build_file = "@//third_party/intellij_sdk:BUILD.idea193", | ||
| sha256 = "fb347c3c681328d11e87846950e8c5af6ac2c8d6a7e56946d3a10e6121d322f9", | ||
| url = "https://www.jetbrains.com/intellij-repository/releases/com/jetbrains/intellij/idea/ideaIC/2019.3.2/ideaIC-2019.3.2.zip", |
There was a problem hiding this comment.
Making sure people have the right version of intellij could be fun
There was a problem hiding this comment.
Yah I don't really know the compatibility here, I just went with the version I have installed now. It's probably worth checking. These deps are set to neverlink so they don't make it into the final deploy jar, so just depends if the IJ API has changed I guess
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds OSS version of bzlgen IntelliJ IDEA plugin for bzlgen
closes #47