Improvement: make Python datasource to use the RestrictedPython sandbox #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…"allowedImportModules" (command separated) will be allowed to be imported and the code assume they are installed on the server running the actual code.
| @@ -28,6 +29,14 @@ | |||
| TYPE_DATETIME = 'datetime' | |||
| TYPE_DATE = 'date' | |||
|
|
|||
| SUPPORTED_COLUMN_TYPES = { | |||
There was a problem hiding this comment.
these are strings, AFAIK, using a dict means the "in" operator will use a hash search instead of matching the strings. In this case I think a set is the same as a list (maybe a bit better because it might be sorted).
There was a problem hiding this comment.
Interesting point, but does it really matter? Considering we're talking about 6 elements and rarely used function? I think the set variant will be easier to understand.
There was a problem hiding this comment.
You are the BDFL :-) will change it to a set.
…we are putting it in the requirements.txt file.
arikfr
changed the title
arikfr
added a commit
that referenced
this pull request
Apr 13, 2015
Improvement: make Python datasource to use the RestrictedPython sandbox
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python datasource that uses RestrictedPython. Only modules listed in "allowedImportModules" (command separated) will be allowed to be imported and the code assume they are installed on the server running the actual code.