Fix root check in BootupService #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: If7977a01b3ac129ce5f92755a10d90c95dd1964f Signed-off-by: Alexander Martinz <eviscerationls@gmail.com>
This was probably why bootup restoration didn't work for me.
|
👍 |
|
whoops, my bad! thanks for keeping an eye on it :) could you please rebase on the master branch again? |
This was probably why bootup restoration didn't work for me.
|
Sorry for the commit mess, my bad |
|
Looks like I made a giant mess. I'm going to make a new PR, sorry for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CPU/GPU frequency settings bootup restoration didn't work for me, so I played around with the bootup code a bit and noticed that the process got aborted if root WAS present.
This is probably how the root check should have been.