Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add documentation settings #51

Closed
johnnychen94 opened this issue Jan 31, 2020 · 4 comments
Closed

add documentation settings #51

johnnychen94 opened this issue Jan 31, 2020 · 4 comments
Assignees
Labels
Milestone

Comments

@johnnychen94
Copy link
Collaborator

johnnychen94 commented Jan 31, 2020

The last thing to do before registering v0.6.0 in the General registry is to update the documentation.

@Evizero Looks like this repository haven't set up auto-deployment CI for documentation, right? Can you add a deploy key and a secret key (with name DOCUMENTER_KEY) following the instruction of https://juliadocs.github.io/Documenter.jl/stable/man/hosting/#travis-ssh-1 I plan to set the documentation via Github action

@johnnychen94 johnnychen94 modified the milestones: v0.7, v0.6 Jan 31, 2020
@Evizero Evizero self-assigned this Jan 31, 2020
@Evizero
Copy link
Owner

Evizero commented Jan 31, 2020

If the docs are still the way I did them then they don't really work in a CI environment

@johnnychen94
Copy link
Collaborator Author

johnnychen94 commented Jan 31, 2020

I'm modifying the docs to adapt the current Documenter system; the idea is to rewrite them using DemoCards.jl, which is CI friendly :P

@johnnychen94
Copy link
Collaborator Author

johnnychen94 commented Feb 12, 2020

Hmmm.. May I tag v0.6.0 in spite of the not updated documents? I need this package registered/tagged for reproduction consideration.

@Evizero
Copy link
Owner

Evizero commented Feb 13, 2020

sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants