Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support iOS 13 features (such as Dark Mode) #122

Merged
merged 7 commits into from Dec 2, 2019

Conversation

uuttff8
Copy link
Contributor

@uuttff8 uuttff8 commented Nov 27, 2019

Changes in this pull request

Support Swift 5
Support Dark Mode
Add SVProgressHud as expected
Add named colors

Issue fixed:

Issues in this pull request

Markdown in proposal still light mode only

Checklist

  • Project builds and runs as expected.
  • No new linting violations have been introduced.
  • No new bugs have been introduced.
  • I have reviewed the contributing guide
  • I'm attaching to this PR some screenshots (if applicable)

@uuttff8 uuttff8 changed the title add init impl Support iOS 13 features (such as Dark Mode) Nov 27, 2019
@unnamedd
Copy link
Member

unnamedd commented Nov 27, 2019

Hi @uuttff8, thanks a lot for your PR!
As soon as possible I will review in detail your changes, quickly looking I didn’t see any problem.

Thanks to bring the dark mode to the project!

I really appreciated your effort!

@uuttff8
Copy link
Contributor Author

uuttff8 commented Nov 28, 2019

Screen Shot 2019-11-28 at 9 58 20 PM

now navigation title color is ok

Copy link
Member

@unnamedd unnamedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far, I do not have any comments to do here. Just say a huge Thank You for your time giving some love to the code and bringing support to Swift 5, what I couldn't stop to do.

@unnamedd
Copy link
Member

@uuttff8, do not forget to add yourself as a contributor here (README) and here (About section).

@uuttff8
Copy link
Contributor Author

uuttff8 commented Nov 29, 2019

@unnamedd all done!

@unnamedd unnamedd merged commit 9ee2e9b into Evolution-App:development Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants