Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Year's PR: iPad icons and support #92

Merged
merged 7 commits into from Dec 30, 2017

Conversation

LeonardoCardoso
Copy link
Member

Changes in this pull request

  • Fresh icons
  • iPad Support

Issue fixeds: #62 #84

Checklist

  • Project builds and runs as expected.
  • No new linting violations have been introduced.
  • I have reviewed the contributing guide
  • I'm attaching to this PR some screenshots (if applicable)

Icons

screen shot 2017-12-29 at 18 53 22

screen shot 2017-12-29 at 18 53 26

iPad Support

Portrait

simulator screen shot - ipad pro 9 7-inch - 2017-12-29 at 16 43 39
simulator screen shot - ipad pro 9 7-inch - 2017-12-29 at 16 43 47
simulator screen shot - ipad pro 9 7-inch - 2017-12-29 at 16 43 51

Landscape

simulator screen shot - ipad pro 9 7-inch - 2017-12-29 at 16 43 59
simulator screen shot - ipad pro 9 7-inch - 2017-12-29 at 16 44 01

Form Sheets

simulator screen shot - ipad pro 9 7-inch - 2017-12-29 at 16 44 09
simulator screen shot - ipad pro 9 7-inch - 2017-12-29 at 17 05 16

- Refreshed Icons
- iPad Icons

#84
- About Scene
- Allow rotation for iPads on whole app
- Allow rotation for iPhones only on Proposal controller

#62
Both landscape and portrait

#62
@LeonardoCardoso LeonardoCardoso changed the title Happy New Year's PR: iPad icons and support New Year's PR: iPad icons and support Dec 29, 2017
Copy link
Contributor

@insidegui insidegui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good :)

Copy link
Member

@unnamedd unnamedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LeonardoCardoso, after some tests, let me give you some feedback:

  • Share proposal isn't working
  • After changing the display mode of proposal detail to full screen, there is no chance to come back, only tapping on "Evolution". Will be nice to have this option instead 'kill' this button.
  • If there is no proposal selected, will be nice to not show the full screen and share buttons.

@unnamedd unnamedd added this to In Progress in Swift Evolution Dec 30, 2017
@LeonardoCardoso
Copy link
Member Author

@unnamedd I’ll take a look!

@LeonardoCardoso
Copy link
Member Author

@unnamedd The "full screen button" is part of the UISplitViewController fragment, and that is the default behavior: Full Screen -> Back Button. It's actually hiding the master controller, not really going full screen. I didn't find a way to hide that button at will without keeping showing Master and Details at the same time.

There are three different modes on UISplitViewController:

  • primaryHidden: Hide the master controller when the split controller is shown, without the "full screen button";
  • primaryOverlay: Show the master controller over the details when the split controller is shown, without the "full screen button";
  • allVisible: Show both at the same time with the "full screen button" when the split controller is shown.

Share Button

It's being displayed only when the proposal is loaded.

Share Action

simulator screen shot - ipad pro 9 7-inch - 2017-12-30 at 14 16 27
simulator screen shot - ipad pro 9 7-inch - 2017-12-30 at 14 16 22

Copy link
Member

@unnamedd unnamedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. Thank you @LeonardoCardoso for the changes.

@unnamedd unnamedd merged commit f059090 into Evolution-App:development Dec 30, 2017
@unnamedd unnamedd moved this from In Progress to Done in Swift Evolution Dec 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
3 participants