New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Year's PR: iPad icons and support #92
New Year's PR: iPad icons and support #92
Conversation
- About Scene
- Allow rotation for iPads on whole app - Allow rotation for iPhones only on Proposal controller #62
Both landscape and portrait #62
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LeonardoCardoso, after some tests, let me give you some feedback:
- Share proposal isn't working
- After changing the display mode of proposal detail to full screen, there is no chance to come back, only tapping on "Evolution". Will be nice to have this option instead 'kill' this button.
- If there is no proposal selected, will be nice to not show the full screen and share buttons.
@unnamedd I’ll take a look! |
- According to proposal existence
@unnamedd The "full screen button" is part of the There are three different modes on
Share ButtonIt's being displayed only when the proposal is loaded. Share Action |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now. Thank you @LeonardoCardoso for the changes.
Changes in this pull request
Issue fixeds: #62 #84
Checklist
Icons
iPad Support
Portrait
Landscape
Form Sheets