Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Sorry for the big PR, I didn't write this much of code.
The old
rakelib
is a pet project that started in MyWeight, and I ported to Swifte-evolution. Later I create a new project to make easy to be used in other projects.This project is xcode-rakelib, and I added here as git subtree.
The main advantage of use
xcode-rakelib
is that the project configuration is done inrake-config.yml
instead of messing directly with the rakelib files.The current tasks supported are:
Another question is why git subtree instead of git submodules?
With subtree, all the files are committed to the project, so there is no need to run any additional command on project setup. If we need to update to a new version of
xcode-rakelib
is needed to run:But most of the users don't need to bother with this.
Otherwise, If we choose to use submodules after each
git clone
will be necessary to rungit submodule update --init --recursive
to be able to run any rake task, includingrake setup.
I think this is not very friendly.The next step is to configure Danger on the CI. It looks like the project is using Bitrise but I didn't find any config file.
Checklist