Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when the image does not exist. #10

Closed
rudacs opened this issue Aug 17, 2019 · 3 comments
Closed

Crash when the image does not exist. #10

rudacs opened this issue Aug 17, 2019 · 3 comments
Labels
bug Something isn't working

Comments

@rudacs
Copy link

rudacs commented Aug 17, 2019

Bug Information

Version Number of Plugin: 2.0.1
Device Tested On: iPhone X
Simulator Tested On: iPhone X
Version of VS: 8.2.3
Version of Xamarin: 12.14.0.114
Versions of other things you are using:

Steps to reproduce the Behavior

Create Image and set image does not exist (local or remote).

Expected Behavior

No crash. And continue the animation.

Actual Behavior

Crash.

Error

System.NullReferenceException: Object reference not set to an instance of an object
at Plugin.SharedTransitions.Platforms.iOS.ViewExtensions.GetImageFrame (UIKit.UIImageView imageView)

@GiampaoloGabba
Copy link
Owner

well, good find! I havent tested with nonexisting images. I will fix this, in the meantime i suggest to use existing images :)

GiampaoloGabba added a commit that referenced this issue Aug 17, 2019
@GiampaoloGabba
Copy link
Owner

This is fixed in master branch. I'll pubblish a new nuget when i'll fix the pop transition duration in issue #11
Thank you for your report!

@rudacs
Copy link
Author

rudacs commented Aug 17, 2019

Thanks for this amazing component. I found out that I didn't put the image in the project.

@GiampaoloGabba GiampaoloGabba added the bug Something isn't working label May 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants