You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This can easily be fixed by changing this code to do an instanceof check. Also, particularly if auto output to other fluid handlers is not desired, there are ways to implement this behavior without requiring ticking at all [pushing or pulling fluids only after the fluid content is changed], or only requiring the bottom tank to tick, but that would be a much more involved change.
The push down behavior could also be made block state dependent [i.e. simply exit the tick method for BOT and ONE tank blocks], though this approach may be vulnerable to problems caused by cross-mod interactions resulting in the block states being arranged incorrectly.
The text was updated successfully, but these errors were encountered:
Describe the bug
The code for moving fluids into the bottom tank breaks if any other tile entity is present below a tank
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Nothing [or possibly auto output into adjacent non-ITank fluid handler]
Additional context
https://github.com/EwyBoy/ITank/blob/1.16/src/main/java/com/ewyboy/itank/common/content/tank/TankTile.java#L69
This can easily be fixed by changing this code to do an instanceof check. Also, particularly if auto output to other fluid handlers is not desired, there are ways to implement this behavior without requiring ticking at all [pushing or pulling fluids only after the fluid content is changed], or only requiring the bottom tank to tick, but that would be a much more involved change.
The push down behavior could also be made block state dependent [i.e. simply exit the tick method for BOT and ONE tank blocks], though this approach may be vulnerable to problems caused by cross-mod interactions resulting in the block states being arranged incorrectly.
The text was updated successfully, but these errors were encountered: