Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server Placeholder not working for player joins Velocity #47

Open
Aiidoneus opened this issue Dec 5, 2023 · 4 comments
Open

Server Placeholder not working for player joins Velocity #47

Aiidoneus opened this issue Dec 5, 2023 · 4 comments
Labels
dependencies Pull requests that update a dependency file

Comments

@Aiidoneus
Copy link

Describe the bug
From what I can tell, the %server% placeholder doesn't work for Player Login logging

To Reproduce
Steps to reproduce the behavior:

  1. Try logging "Player Login" and see the placeholder not working
  2. See in the logs it printing [%server%] rather than the actual server

Expected behavior
Should display what server they have connected too.

The placeholder does work for "Player Leave" and other things like "Player Commands".

Screenshots
N/A

Server & Version (please complete the following information):

  • Logger Version: Logger-1.8.0.11.jar
  • Server Type: Velocity-3.2.0-SNAPSHOT-294.jar
@DICEALPHAHU DICEALPHAHU added the dependencies Pull requests that update a dependency file label Dec 11, 2023
@DICEALPHAHU
Copy link
Collaborator

plz send dump file to us
/logger dump

@Aiidoneus
Copy link
Author

plz send dump file to us /logger dump

This is not a thing on Velocity version of logger. From what I can tell, it is only a spigot thing.

https://github.com/ExceptedPrism3/Logger/blob/Improving/Logger-Spigot/src/main/java/me/prism3/logger/commands/subcommands/Dump.java

@Aiidoneus
Copy link
Author

Looking at this, doesn't look like any of the replacers were ever added for PostLogin Event for %sever% See as an example:
https://github.com/ExceptedPrism3/Logger/blob/a02a383fd47122edf47bdd77051b5925e26b9966/Logger-Velocity/src/main/java/me/prism3/loggervelocity/events/OnLogin.java#L51C74-L51C74

I see it is added on the Disconnected event
https://github.com/ExceptedPrism3/Logger/blob/a02a383fd47122edf47bdd77051b5925e26b9966/Logger-Velocity/src/main/java/me/prism3/loggervelocity/events/OnLeave.java#L45C17-L45C17

This might just have been forgotten? Or is there a different reason?

@DICEALPHAHU
Copy link
Collaborator

@ExceptedPrism3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

2 participants