Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fishing with Croptopia installed always yields two items instead of one #602

Open
1 task done
herebecush opened this issue Mar 3, 2024 · 4 comments
Open
1 task done
Labels
bug Something isn't working

Comments

@herebecush
Copy link

Make sure you are not opening a duplicate.

Platform.

Fabric

Minecraft version.

1.20.4

Croptopia version.

3.0.1

What happened?

Every time that someone fishes on our server with Croptopia installed (tested with nothing else except Croptopia + EpheroLib), they always receive two items instead of one. It seems like somewhere inside the mod perhaps some sort of "give item" command is giving them a Croptopia item on top of the vanilla item rather than, as intended, instead of the vanilla item.

Relevant log.

No response

Additional information.

No response

@herebecush herebecush added the bug Something isn't working label Mar 3, 2024
@herebecush
Copy link
Author

Having looked into the source code the only part I can see potentially impacting this is in /fabric/src/main/java/com/epherical/croptopiaitems/CropLootTableModifier.java around lines 36 - 48... perhaps this is adding a second loot table lookup to take items from rather than amending the existing loot table and then Minecraft is selecting one from each rather than selecting one from either.

@herebecush
Copy link
Author

Additionally I have tried building the mod myself using ./gradlew :fabric:build as outlined in this repo's README file, but I receive this error:
image

@herebecush
Copy link
Author

bump

Any idea of what can be done as a quick first step on either the fish issue or the gradle issue?

@herebecush
Copy link
Author

@ExcessiveAmountsOfZombies Any assistance on this would be appreciated, even if it's just how to get the build working so I can modify the mod myself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant