Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify response packet type #788

Closed
moshababo opened this issue Jan 16, 2019 · 1 comment
Closed

Verify response packet type #788

moshababo opened this issue Jan 16, 2019 · 1 comment
Assignees
@moshababo
Labels
bug Something isn't working p2p Peer to peer networking security securing xud from unauthorized actions
Milestone
1.0.0-sprint.13

Comments

@moshababo
Copy link
Collaborator

Currently we're not verifying the response packet type for each request - only that its reqId is matching the request packet Id. This can lead to runtime exceptions and node crash.
@moshababo moshababo added bug Something isn't working p2p Peer to peer networking security securing xud from unauthorized actions labels Jan 16, 2019
@moshababo moshababo added this to the 1.0.0-alpha.8 milestone Jan 16, 2019
@moshababo moshababo self-assigned this Jan 16, 2019
@moshababo moshababo mentioned this issue Jan 16, 2019
Merged
@moshababo moshababo modified the milestones: 1.0.0-alpha.8, 1.0.0-alpha.9 Feb 4, 2019
@kilrau kilrau modified the milestones: 1.0.0-alpha.9, 1.0.0-alpha.10 Feb 20, 2019
@kilrau kilrau modified the milestones: 1.0.0-alpha.10, 1.0.0-alpha.11, 1.0.0-beta.1 Feb 27, 2019
@kilrau kilrau assigned erkarl and unassigned erkarl Mar 6, 2019
@kilrau
Copy link
Contributor

kilrau commented Mar 6, 2019

Who's interested in this one? @erkarl @sangaman @reliveyy

@moshababo moshababo self-assigned this Mar 14, 2019
@kilrau kilrau modified the milestones: 1.0.0-sprint.12, 1.0.0-sprint.13 Mar 26, 2019
@moshababo moshababo mentioned this issue Mar 30, 2019
Merged
@ghost ghost added the in progress label Mar 30, 2019
@ghost ghost removed the in progress label Apr 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@moshababo moshababo

Labels
bug Something isn't working p2p Peer to peer networking security securing xud from unauthorized actions
Projects
None yet
Milestone
1.0.0-sprint.13
Development

No branches or pull requests
3 participants
@erkarl @moshababo @kilrau