Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a copy method to celloutputbundlenode #153

Merged
merged 2 commits into from
Apr 20, 2020

Conversation

AakashGfude
Copy link
Member

Added a copy method which also takes outputs as argument

fixes #151

@codecov
Copy link

codecov bot commented Apr 17, 2020

Codecov Report

Merging #153 into master will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #153      +/-   ##
==========================================
+ Coverage   83.85%   83.89%   +0.04%     
==========================================
  Files           9        9              
  Lines         805      807       +2     
==========================================
+ Hits          675      677       +2     
  Misses        130      130              
Flag Coverage Δ
#pytests 83.89% <100.00%> (+0.04%) ⬆️
Impacted Files Coverage Δ
myst_nb/transform.py 73.13% <ø> (ø)
myst_nb/parser.py 91.27% <100.00%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b750c1a...d0ca6f4. Read the comment docs.

@choldgraf
Copy link
Member

Is this something that we could add a test for?

@AakashGfude
Copy link
Member Author

@choldgraf we can test this as a part of a latex build in test_transform?

@choldgraf
Copy link
Member

sure - I just wanna make sure that the bug we think we are fixing doesn't re-surface :-)

@AakashGfude
Copy link
Member Author

Hey @choldgraf , what do you think about the test added?

@choldgraf
Copy link
Member

it looks good to me - is it a test that would have failed w/o the copy method?

@AakashGfude
Copy link
Member Author

AakashGfude commented Apr 20, 2020

@choldgraf , yes it would not have been able to replace <CelloutputBundleNode> with specific mime-type nodes. And would have failed

@choldgraf
Copy link
Member

Great - I'll merge tomorrow AM unless somebody else suggests otherwise 👍 nice job @AakashGfude !

@choldgraf choldgraf merged commit d436887 into executablebooks:master Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CellOutputNodeBundle has output_count="0" in case of --build latexpdf
2 participants