Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sphinxcontrib-sphinx test for missing reference #97

Closed
wants to merge 15 commits into from

Conversation

chrisjsewell
Copy link
Member

@mtiley I have tried to replicate your issue in #95, but I do not find this issue.

Can you try using this fork, to run:

$ pytest tests/test_sphinx/test_sphinx_builds.py::test_bibtex_norefs

and let me know if it passes. If it does pass, then maybe try to have a look at the test I have written, and see if you can alter it to fail with your issue.
You may want to take a look at https://myst-parser.readthedocs.io/en/latest/develop/test_infrastructure.html#test-tools re: pytest-regressions.

@chrisjsewell
Copy link
Member Author

If you didn't know, to use this branch do:

git clone https://github.com/ExecutableBookProject/MyST-Parser
cd MyST-Parser
git checkout fix-bibtex-95-rebase
pip install -e .[sphinx,code_style,testing,rtd]

@chrisjsewell chrisjsewell changed the title Add sphinx-contrib test for missing reference Add sphinxcontrib-sphinx test for missing reference Mar 2, 2020
@chrisjsewell
Copy link
Member Author

chrisjsewell commented Mar 2, 2020

In b26aa42, I've tried adding documents that might replicate your issue in the documentation:

I don't see your issue,
but @choldgraf this has caused some crazy formatting issues; with the top of pages not showing, and the next/previous buttons not rendered correctly. How have I done that!?

@chrisjsewell
Copy link
Member Author

chrisjsewell commented Mar 2, 2020

but @choldgraf this has caused some crazy formatting issues; with the top of pages not showing, and the next/previous buttons not rendered correctly. How have I done that!?

Ah my bad, I hadn't added --keep-going to make html-strict, to make sure the build still completes on warnings, but returns a non-zero exit code. (Was sure I'd added this but obviously not!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant