Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👌 Improve directive parsing warnings #893

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

chrisjsewell
Copy link
Member

Minor improvement to the specificity of warnings regarding problems encountered when parsing directives

Minor improvement to the specificity of warnings regarding problems encountered when parsing directives
@codecov-commenter
Copy link

codecov-commenter commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 90.06%. Comparing base (978e845) to head (ee4ae60).

Files Patch % Lines
myst_parser/parsers/directives.py 81.25% 3 Missing ⚠️
myst_parser/mocking.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #893      +/-   ##
==========================================
+ Coverage   90.04%   90.06%   +0.02%     
==========================================
  Files          24       24              
  Lines        3364     3372       +8     
==========================================
+ Hits         3029     3037       +8     
  Misses        335      335              
Flag Coverage Δ
pytests 90.06% <80.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrisjsewell chrisjsewell merged commit daa00c6 into master Mar 26, 2024
20 checks passed
@chrisjsewell chrisjsewell deleted the improve-directive-parsing-errors branch March 26, 2024 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants