Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing overlap problems in docs #108

Closed
wants to merge 3 commits into from

Conversation

choldgraf
Copy link
Member

This changes the theme to the sphinx-book-theme so it's easier to notice issues on that theme specifically, and also adds some documentation blocks that highlight a few bugs that are present so we can more easily fix them in the future.

@chrisjsewell
Copy link
Member

@choldgraf we should set up the testing the same as in sphinx-panels, to easily run the docs against different themes

@choldgraf
Copy link
Member Author

@chrisjsewell yeah I agree - I really like that pattern. Do you think there's a way that we could generalize that pattern so that it's not a bunch of hand set-up for each repo?

@chrisjsewell
Copy link
Member

Do you think there's a way that we could generalize that pattern so that it's not a bunch of hand set-up for each repo?

setting it up with the HTML_THEME environmental variable means the only difference in the branches is just the default theme: https://github.com/executablebooks/sphinx-panels/compare/alabaster-theme,
which is pretty general

@choldgraf
Copy link
Member Author

thanks for those tips - I opened an issue to discuss documenting this + keep track of these links over here: executablebooks/meta#199

@choldgraf choldgraf force-pushed the overlap-problems branch 3 times, most recently from b563068 to 772e58c Compare December 6, 2020 22:24
@choldgraf
Copy link
Member Author

closing this because we now demonstrate this bug in our reference page: https://sphinx-copybutton.readthedocs.io/en/latest/reference/example.html

@choldgraf choldgraf closed this Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants