Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle app with version name with > 50 characters #300

Open
pnu-s opened this issue Dec 28, 2019 · 6 comments
Open

Handle app with version name with > 50 characters #300

pnu-s opened this issue Dec 28, 2019 · 6 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@pnu-s
Copy link
Member

pnu-s commented Dec 28, 2019

Currently there is a bug with application which versions / version codes have more than 50 characters.

This is not handled properly so the analysis hangs forever with the message "Tracker analysis: success"

Example: https://play.google.com/store/apps/details?id=ch.sbb.mobile.android.preview and its version flavorpreviewRelease-10.0.0.191210.1822.126-RELEASE

Couple of possible solutions:

  • extend the max characters limit
  • truncate the version and version codes when saving them
  • refuse app with version/version code > 50 characters
@pnu-s pnu-s added bug Something isn't working good first issue Good for newcomers labels Dec 28, 2019
@codeurimpulsif
Copy link
Contributor

codeurimpulsif commented Dec 28, 2019

I think extend the max characters limit in database is a good solution.
(Truncating leads to information loss and I think it's better to have complete values)

Maybe we can try with 100 characters ?

@pnu-s
Copy link
Member Author

pnu-s commented Dec 28, 2019

Agreed, makes sense to me :)

What we could do:

  • increase the limit in DB to 100 characters
  • in templates, in case the version is longer than 30/40 characters, truncate it and add a tooltip

@pnu-s
Copy link
Member Author

pnu-s commented Dec 29, 2019

Got the same issue this morning with a permission too long (https://play.google.com/store/apps/details?id=com.sec.android.app.sbrowser.beta)

Not sure if this is related to a recent change as I don't think so we were seeing this before but we need to at least handle these cases properly

@pnu-s
Copy link
Member Author

pnu-s commented Jan 8, 2020

Note: I made a quick change to fail properly when this happens instead of hanging forever

@Jean-BaptisteC
Copy link
Contributor

Since june 2021, i have analyse more 10 000 apps and the number of apps with versionName have more 50 characters is weak.
https://play.google.com/store/apps/details?id=com.google.android.tts

@U039b
Copy link
Contributor

U039b commented May 16, 2022

We could increase the limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants