Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Querying locations for a specific province takes time #42

Closed
neelr opened this issue Mar 14, 2020 · 2 comments · Fixed by #69
Closed

Querying locations for a specific province takes time #42

neelr opened this issue Mar 14, 2020 · 2 comments · Fixed by #69
Labels
enhancement New feature or request

Comments

@neelr
Copy link

neelr commented Mar 14, 2020

I'll make a PR, but when you query for a province in locations, its a large array, so it would be easier to return a object with province and if null then country

@ExpDev07
Copy link
Owner

Could you give an example of object returned?

@ExpDev07 ExpDev07 added the enhancement New feature or request label Mar 14, 2020
@neelr
Copy link
Author

neelr commented Mar 14, 2020

instead of

[
{... specificProvinceData}
]

it would be

{
      proviceOrCountry:{... specificProvinceData}
}

@ExpDev07 ExpDev07 linked a pull request Mar 18, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants