Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest kotlin and fix incorrect jackson version in the example #233

Merged
merged 1 commit into from Jun 6, 2019

Conversation

dariuszkuc
Copy link
Collaborator

No description provided.

Copy link
Contributor

@Macarse Macarse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@smyrick smyrick added the changes: patch Changes require a patch version label Jun 6, 2019
@smyrick smyrick added the type: dependency changes Dependency change which doesn't affect our library usage label Jun 6, 2019
@smyrick
Copy link
Contributor

smyrick commented Jun 6, 2019

@dkuc84 There are test failures on JDK 11

[ERROR] Failures: 
[ERROR]   FunctionDataFetcherTest.suspendThrow throws exception when resolved:166 Expected value to be true.
[INFO] 
[ERROR] Tests run: 253, Failures: 1, Errors: 0, Skipped: 0

@codecov
Copy link

codecov bot commented Jun 6, 2019

Codecov Report

Merging #233 into master will decrease coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #233      +/-   ##
============================================
- Coverage     98.43%   98.28%   -0.16%     
  Complexity      178      178              
============================================
  Files            57       57              
  Lines           575      583       +8     
  Branches         99      103       +4     
============================================
+ Hits            566      573       +7     
  Misses            4        4              
- Partials          5        6       +1
Impacted Files Coverage Δ Complexity Δ
...m/expedia/graphql/execution/FunctionDataFetcher.kt 86.95% <0%> (-3.96%) 11% <0%> (ø)
...expedia/graphql/generator/types/FunctionBuilder.kt 100% <0%> (ø) 13% <0%> (ø) ⬇️
.../com/expedia/graphql/generator/state/TypesCache.kt 100% <0%> (ø) 21% <0%> (ø) ⬇️
...raphql/generator/extensions/kPropertyExtensions.kt 100% <0%> (ø) 0% <0%> (ø) ⬇️
...otlin/com/expedia/graphql/DirectiveWiringHelper.kt 100% <0%> (ø) 11% <0%> (ø) ⬇️
...otlin/com/expedia/graphql/generator/TypeBuilder.kt 100% <0%> (ø) 19% <0%> (ø) ⬇️
.../graphql/generator/extensions/graphQLExtensions.kt 91.3% <0%> (+0.39%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bf396e...d86463a. Read the comment docs.

@dariuszkuc
Copy link
Collaborator Author

Looks like a flaky test - it was successful on rerun

@dariuszkuc dariuszkuc merged commit 81658da into master Jun 6, 2019
@dariuszkuc dariuszkuc deleted the lib_version_update branch June 6, 2019 19:06
dariuszkuc added a commit to dariuszkuc/graphql-kotlin that referenced this pull request Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes: patch Changes require a patch version type: dependency changes Dependency change which doesn't affect our library usage
Development

Successfully merging this pull request may close these issues.

None yet

3 participants