Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update TypeNotSupportedException message #236

Merged
merged 1 commit into from Jun 7, 2019
Merged

Conversation

smyrick
Copy link
Contributor

@smyrick smyrick commented Jun 7, 2019

Update the exception message to be clear about the situations in which the exception can be thrown. One of the most common questions we get is around trying to use Map<> which is not a valid type for a GraphQL schema.

Update the exception message to be clear about the situations in which the exception can be thrown. One of the most common questions we get is around trying to use ` Map<>` which is not a valid type for a GraphQL schema.
@smyrick smyrick added changes: patch Changes require a patch version type: documentation Documentation or test changes labels Jun 7, 2019
@codecov
Copy link

codecov bot commented Jun 7, 2019

Codecov Report

Merging #236 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #236   +/-   ##
=========================================
  Coverage     98.28%   98.28%           
  Complexity      178      178           
=========================================
  Files            57       57           
  Lines           583      583           
  Branches        103      103           
=========================================
  Hits            573      573           
  Misses            4        4           
  Partials          6        6
Impacted Files Coverage Δ Complexity Δ
...ia/graphql/exceptions/TypeNotSupportedException.kt 100% <100%> (ø) 1 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 035f6b1...3e05eb4. Read the comment docs.

Copy link
Collaborator

@dariuszkuc dariuszkuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Map is outside the supported packages....

@dariuszkuc dariuszkuc merged commit 625dafa into master Jun 7, 2019
@dariuszkuc dariuszkuc deleted the smyrick-patch-1 branch June 7, 2019 21:52
dariuszkuc pushed a commit to dariuszkuc/graphql-kotlin that referenced this pull request Aug 5, 2022
Update the exception message to be clear about the situations in which the exception can be thrown. One of the most common questions we get is around trying to use ` Map<>` which is not a valid type for a GraphQL schema.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes: patch Changes require a patch version type: documentation Documentation or test changes
Development

Successfully merging this pull request may close these issues.

None yet

2 participants